Conversation
Update links and refer to datasources explicitly
Update README
Refers to mapnik PR #3512
|
@artemp It would useful to get some feedback on the queries above (particularly the query about |
|
@dch0ph - apologies for taking long to reply. I'll reply properly first thing tomorrow, thanks for your effort! |
|
@dch0ph - Just looking at Implementation in https://github.com/mapnik/mapnik/blob/master/include/mapnik/extend_converter.hpp suggests it can be applied to any geometry not just a line. @talaj - are you around? could you verify the above statement ^ Also, cool FSM 👍 |
As far as I can see all
Here's some pointers Looks like most if not all can be expressions also.. |
There was a problem hiding this comment.
Looks like this shouldn't be in v3.1.0
There was a problem hiding this comment.
Looks like this shouldn't be in
v3.1.0
That would be consistent with not finding extend in my 3.1 library.
This would make this wiki page incorrect. So we could do with either a wiki page or a separate issue for 3.1 -> 4.x changes and move extend there.
There was a problem hiding this comment.
It looks like the whole section https://github.com/mapnik/mapnik/wiki/API-changes-between-v3.0-and-v3.1#added
is wrong and shouldn't be in v3.1.0.
There was a problem hiding this comment.
2 participants
A draft attempt to document PR #3512.
Queries:
expressions: trueneeds checking. I didn't know how to determine from the code whether expressions would be supported.extendkey is parsed inparse_symbolizer_base, which is used by multiple symbolizers rather than just Line. Is this correct? But presumably it only makes sense to documentextendfor the line symbolizer?I would like to have a way to double-check that a given property is present in 3.1.0. I would have expected "extend" to be found when using
strings libmapnik.so.3.1.0, but it drew a blank. I triedscripts/validate_mapnik_instance.py, but I don't think this will work unless the python bindings match 3.1.0 (which they didn't seem to).I do think it would be helpful to retrospectively create an approximate entry in the mapnik
CHANGELOG.mdto separate out then changes up to 3.1. It looks like everything after 3.0.20 has been lumped under the 4.0.0 entry?